Messages in this thread | | | Date | Wed, 1 Oct 2008 01:36:55 -0700 | From | "Steven Noonan" <> | Subject | Re: [PATCH -tip] drivers/serial/8250.c: 'i' may be used uninitialized |
| |
On Wed, Oct 1, 2008 at 1:29 AM, Ingo Molnar <mingo@elte.hu> wrote: > > * Steven Noonan <steven@uplinklabs.net> wrote: > >> Signed-off-by: Steven Noonan <steven@uplinklabs.net> >> --- >> drivers/serial/8250.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > the change is obvious to you, but it's useful to put an analysis into > the changelog. Something like: > > serial_unlink_irq_chain() does not initialize iterator 'i', and that is > correct logically because it is always initialized due to XYZ. Gcc does > not realize this connection and emits a false warning. Annotate it with > uninitialized_var(). > > and fill in XYZ. > > Doing such changelogs is useful to maintainers: they'll see that you > havent just squashed a warning you noticed, you understood the code and > determined it via review that the warning is GCC's fault, not the > kernel's. > > with an empty changelog the maintainer will have to do this himself. > (and can easily put your patch to the tail of a very long TODO list, or > outright skip your patch.) > > Ingo >
I was kind of worried about being exceedingly verbose, but I understand your point perfectly. I'm going to resend the patch with an appropriately verbose comment.
As always, I appreciate the criticism. Thank you! :)
- Steven
| |