lkml.org 
[lkml]   [2008]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] drivers/serial/8250.c: 'i' may be used uninitialized

* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> On Wed, 1 Oct 2008 10:01:50 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
>
> >
> > ( Alan Cc:-ed. Seems like gcc bogosity - so your solution of using
> > uninitialized_var() is the correct way to annotate this. )
>
> Sorry but uninitialized_var() is too ugly to be acceptable. Please use
> a proper __foo style notation for consistency with the rest of the
> kernel

it cannot be wrapped like that via __foo style notation (which can be
used for section tricks), and uninitialized_var() is the accepted
upstream facility for this, it got introduced 1.5 years ago, via commit
94909914 ("Add unitialized_var() macro for suppressing gcc warnings").

> (Besides which last time I checked current gcc could figure that one
> out)

that would indeed moot the patch.

Ingo


\
 
 \ /
  Last update: 2008-10-01 13:01    [from the cache]
©2003-2011 Jasper Spaans