[lkml]   [2008]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH -tip] drivers/serial/8250.c: 'i' may be used uninitialized

    * Alan Cox <> wrote:

    > On Wed, 1 Oct 2008 10:01:50 +0200
    > Ingo Molnar <> wrote:
    > >
    > > ( Alan Cc:-ed. Seems like gcc bogosity - so your solution of using
    > > uninitialized_var() is the correct way to annotate this. )
    > Sorry but uninitialized_var() is too ugly to be acceptable. Please use
    > a proper __foo style notation for consistency with the rest of the
    > kernel

    it cannot be wrapped like that via __foo style notation (which can be
    used for section tricks), and uninitialized_var() is the accepted
    upstream facility for this, it got introduced 1.5 years ago, via commit
    94909914 ("Add unitialized_var() macro for suppressing gcc warnings").

    > (Besides which last time I checked current gcc could figure that one
    > out)

    that would indeed moot the patch.


     \ /
      Last update: 2008-10-01 13:01    [W:0.024 / U:61.420 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site