Messages in this thread | | | Date | Wed, 9 Jan 2008 09:08:00 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH] Kprobes: Add kprobes smoke tests that run on boot |
| |
On Wed, Jan 09, 2008 at 08:00:03AM +0000, Christoph Hellwig wrote: > On Tue, Jan 08, 2008 at 11:18:02PM +0100, Ingo Molnar wrote: > > > > * Andi Kleen <andi@firstfloor.org> wrote: > > > > > Ananth N Mavinakayanahalli <ananth@in.ibm.com> writes: > > > > kernel/kprobes.c | 2 > > > > kernel/test_kprobes.c | 216 ++++++++++++++++++++++++++++++++++++++++++++++++ > > > > > > Can you put this somewhere else please? I know there are already some > > > test files in kernel/* but imho they all belong into some other > > > directory. > > > > agreed - lib/* would be the right place i think - we've got > > lib/locking-selftest.c already. > > Actually the right place would be to have a separate toplevel directory > I think, and a separate menu in the kernel config machinery. Thay way > tests are in one place and easily spottable.
Seconded...
Sam
| |