Messages in this thread |  | | Date | Wed, 9 Jan 2008 22:40:26 +0000 | From | Alasdair G Kergon <> | Subject | Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl |
| |
On Wed, Jan 09, 2008 at 02:12:40PM -0600, Matt Mackall wrote: > You'll need to change the prototype, the unlocked version doesn't take > an inode. And you'll need to make sure that nothing in the function uses > the inode, which I think Andi forgot to mention.
This old chestnut again. Perhaps we could have inode passed to unlocked_ioctl? I never understood why it wasn't there in the first place if the plan was for .unlocked_ioctl to supercede .ioctl whenever possible.
Device-mapper for example in dm_blk_ioctl(), has no need for BKL so drops it immediately, but it does need the inode parameter, so it is unable to switch as things stand.
Alasdair -- agk@redhat.com
|  |