Messages in this thread |  | | From | Rusty Russell <> | Subject | Re: [PATCH] call sysrq_timer_list_show from a workqueue | Date | Thu, 10 Jan 2008 08:58:47 +1100 |
| |
On Thursday 10 January 2008 02:24:40 Paulo Marques wrote: > Rusty Russell wrote: > > Or better, rework all the name lookup interfaces, rather than having: > > Yes, there is some rework we can do here....
Hi Paulo,
Yes, it just needs some thought...
> > extern int sprint_symbol(char *buffer, unsigned long address); > > extern void __print_symbol(const char *fmt, unsigned long address); > > These 2 are probably fine.
Except they're awful for the !CONFIG_KALLSYMS case. You really want something that that prints the name if available and the address otherwise.
> I can do a patch for this, but this will touch a few subsystems that use > these interfaces (there are not a lot of them, though). The major change > would probably be the allocation of a small buffer (56~60 bytes) in some > of the callers to hold the module name.
Indeed.
I look forward to your patch! Rusty.
|  |