lkml.org 
[lkml]   [2008]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
Andre Noll wrote:
> On 17:40, Andi Kleen wrote:
>
>
>> Here's a proposal for some useful code transformations the kernel janitors
>> could do as opposed to running checkpatch.pl.
>>
>
> Here's my take on drivers/scsi/sg.c. It's only compile-tested on x86-64.
>
... and x86 with all(yes|mod)config. :)

Would had preferred:

if (x) {
result = -Exxxx;
goto out;
}

then:

result = -Exxxx;
if (x)
goto out;

but it looks correct.

cu,
Richard



\
 
 \ /
  Last update: 2008-01-09 14:21    [W:0.089 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site