| Date | Wed, 09 Jan 2008 14:17:33 +0100 | From | Richard Knutsson <> | Subject | Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl |
| |
Andre Noll wrote: > On 17:40, Andi Kleen wrote: > > >> Here's a proposal for some useful code transformations the kernel janitors >> could do as opposed to running checkpatch.pl. >> > > Here's my take on drivers/scsi/sg.c. It's only compile-tested on x86-64. > ... and x86 with all(yes|mod)config. :)
Would had preferred:
if (x) { result = -Exxxx; goto out; }
then:
result = -Exxxx; if (x) goto out;
but it looks correct.
cu, Richard
|