lkml.org 
[lkml]   [2008]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.24-rc7, intel audio: alsa doesn't say a beep

* Takashi Iwai <tiwai@suse.de> wrote:

> > The only difference between rc6 and rc7 in sound/pci/hda/hda_intel.c is
> > this:
> >
> > diff -ur linux-2.6.24-rc6/sound/pci/hda/hda_intel.c linux-2.6.24-rc7/sound/pci/hda/hda_intel.c
> > --- linux-2.6.24-rc6/sound/pci/hda/hda_intel.c 2007-12-21 02:25:48.000000000 +0100
> > +++ linux-2.6.24-rc7/sound/pci/hda/hda_intel.c 2008-01-06 22:45:38.000000000 +0100
> > @@ -555,7 +555,8 @@
> > }
> > if (!chip->rirb.cmds)
> > return chip->rirb.res; /* the last value */
> > - schedule_timeout_uninterruptible(1);
> > + udelay(10);
> > + cond_resched();
> > } while (time_after_eq(timeout, jiffies));
> >
> > if (chip->msi) {
> >
> >
> > Do you think this could be related to the problem?
>
> Could you revert it and check whether the problem still exists?
>
> I hardly believe it's the culprit, but if this is the only change in
> the sound subsystem...

lets revert it (commit 57a04513cb3) if it's causing problems. This patch
sat in -mm for quite some time - so it seems -rc7 is getting pretty good
test coverage.

Ingo


\
 
 \ /
  Last update: 2008-01-08 11:13    [W:0.050 / U:40.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site