lkml.org 
[lkml]   [2008]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00 of 10] x86: unify asm/pgtable.h

* Andi Kleen <ak@suse.de> wrote:

> On Wed, Jan 09, 2008 at 02:16:09AM +0100, Ingo Molnar wrote:
> >
> > * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> >
> > > This isn't correct, because it will set _PAGE_GLOBAL on 32-bit
> > > unconditionally. It needs to be something like:
> >
> > hm, why is that a problem?
>
> Not so ancient 32bit CPUs didn't support global.

'not so ancient' like: pre-PPro ones? But we mark the ptes PAGE_GLOBAL
during pagetable init so we should be fine performance-wise.

but yeah, it shouldnt be turned on unconditionally indeed.

Ingo


\
 
 \ /
  Last update: 2008-01-09 02:25    [W:0.060 / U:4.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site