lkml.org 
[lkml]   [2008]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] x86: coding style fixes in arch/x86/ia32/ia32_aout.c
On Tue, Jan 08, 2008 at 03:04:39PM -0500, Rik van Riel wrote:
> On Tue, 8 Jan 2008 20:32:33 +0100
> Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:
>
> > Fix plenty of coding style errors
>
> Most of these kernel changes would probably get in the way of
> real development, making patches reject that would otherwise
> apply.
>
> You did find one possible bug, though:
>
> > @@ -467,9 +465,9 @@ static int load_aout_library(struct file *file)
> >
> > #ifdef WARN_OLD
> > static unsigned long error_time;
> > - if ((jiffies-error_time) > 5*HZ)
> > - {
> > - printk(KERN_WARNING
> > + if ((jiffies-error_time) > 5*HZ) {
> > +
> > + printk(KERN_WARNING
> > "N_TXTOFF is not page aligned. Please convert library: %s\n",
> > file->f_path.dentry->d_name.name);
> > error_time = jiffies;
>
> You may want to look into the time_after() macro and make sure
> it is used here.

It is already fixed in the x86 tree in the mm branch.

So this part would conflict with ongoing development effort...

Sam


\
 
 \ /
  Last update: 2008-01-08 21:55    [W:0.079 / U:4.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site