lkml.org 
[lkml]   [2008]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] x86: coding style fixes in arch/x86/ia32/ia32_binfmt.c
On Jan 8, 2008 9:02 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > static void elf32_init(struct pt_regs *regs)
> > {
> > - struct task_struct *me = current;
> > + struct task_struct *me = current;
> > regs->rdi = 0;
> > regs->rsi = 0;
> > regs->rdx = 0;
> > regs->rcx = 0;
> > regs->rax = 0;
> > - regs->rbx = 0;
> > - regs->rbp = 0;
> > + regs->rbx = 0;
> > + regs->rbp = 0;
> > regs->r8 = regs->r9 = regs->r10 = regs->r11 = regs->r12 =
> > - regs->r13 = regs->r14 = regs->r15 = 0;
> > - me->thread.fs = 0;
> > + regs->r13 = regs->r14 = regs->r15 = 0;
> > + me->thread.fs = 0;
> > me->thread.gs = 0;
> > - me->thread.fsindex = 0;
> > + me->thread.fsindex = 0;
> > me->thread.gsindex = 0;
> > - me->thread.ds = __USER_DS;
> > + me->thread.ds = __USER_DS;
>
> No re-indenting those 4-spaced lines? I mean if you're in CodindStyle
> compliance business driving from 99 to 99.9 percents please do it well
> at least.

Neither checkpatch.pl nor my .vimrc triggered those lines :-/

If Ingo wants to apply the patch I'll update it.

Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/


\
 
 \ /
  Last update: 2008-01-08 21:17    [W:0.033 / U:1.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site