lkml.org 
[lkml]   [2008]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2] kprobes: Introduce is_kprobe_fault()
    Hi,

    Thank you for good work!

    Harvey Harrison wrote:
    > Use a central is_kprobe_fault() inline in kprobes.h to remove all
    > of the arch-dependant, practically identical implementations in
    > avr32, ia64, powerpc, s390, sparc64, and x86.
    >
    > avr32 was the only arch without the preempt_disable/enable pair
    > in its notify_page_fault implementation.
    >
    > This uncovered a possible bug in the s390 version as that purely
    > copied the x86 version unconditionally passing 14 as the trapnr
    > rather than the error_code parameter.
    >
    > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>


    I tested it on x86-64.

    Acked-by: Masami Hiramatsu <mhiramat@redhat.com>

    --
    Masami Hiramatsu

    Software Engineer
    Hitachi Computer Products (America) Inc.
    Software Solutions Division

    e-mail: mhiramat@redhat.com, masami.hiramatsu.pt@hitachi.com



    \
     
     \ /
      Last update: 2008-01-08 18:07    [W:0.021 / U:29.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site