Messages in this thread | | | Subject | Re: [PATCH] Deprecate checkpatch.pl --file | From | Daniel Walker <> | Date | Tue, 08 Jan 2008 08:50:33 -0800 |
| |
On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote:
> +if ($file) { > + print <<EOL > +WARNING: Using --file mode. Please do not send patches to linux-kernel > +that change whole existing files if you did not significantly change most > +of the the file for other reasons anyways or just wrote the file newly > +from scratch. Pure code style patches have a significant cost in a > +quickly changing code base like Linux because they cause rejects > +with other changes. > +If you're sure you want to use whole file mode please use --file-force > +EOL > +; > + exit(1);
Can't say I like this too much .. It sounds like your telling people to stop sending cleanup patches, which doesn't make much sense .. We want a clean kernel .. Or at least I do ..
Linus and Andrew could slow acceptable of these patches, but I don't think discouraging people from cleaning up code and submitting a patch for that is the right thing to do..
(Btw, I changed to akpm@linux-foundation.org and not @osdl.org .. )
Daniel
| |