lkml.org 
[lkml]   [2008]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 06/10] s390: Use generic percpu
    V2->V3:

    On Thu, 29 Nov 2007, Martin Schwidefsky wrote:

    > On Wed, 2007-11-28 at 13:09 -0800, Christoph Lameter wrote:
    > > s390 has a special way to determine the pointer to a per cpu area
    > > plus there is a way to access the base of the per cpu area of the
    > > currently executing processor.
    > >
    > > Note: I had to do a minor change to ASM code. Please check that
    > > this was done right.
    >
    > Hi Christoph,
    >
    > after fixing the trainwreck with Gregs kset changes I've got rc3-mm2
    > compiled with your percpu patches. The new s390 percpu code works fine:
    >
    > Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

    Cc: schwidefsky@de.ibm.com
    Signed-off-by: Christoph Lameter <clameter@sgi.com>
    Signed-off-by: Mike Travis <travis@sgi.com>

    ---
    include/asm-s390/percpu.h | 42 +++++++++---------------------------------
    1 file changed, 9 insertions(+), 33 deletions(-)

    --- a/include/asm-s390/percpu.h
    +++ b/include/asm-s390/percpu.h
    @@ -13,49 +13,25 @@
    */
    #if defined(__s390x__) && defined(MODULE)

    -#define __reloc_hide(var,offset) (*({ \
    +#define SHIFT_PERCPU_PTR(ptr,offset) (({ \
    extern int simple_identifier_##var(void); \
    unsigned long *__ptr; \
    - asm ( "larl %0,per_cpu__"#var"@GOTENT" \
    - : "=a" (__ptr) : "X" (per_cpu__##var) ); \
    - (typeof(&per_cpu__##var))((*__ptr) + (offset)); }))
    + asm ( "larl %0, %1@GOTENT" \
    + : "=a" (__ptr) : "X" (ptr) ); \
    + (typeof(ptr))((*__ptr) + (offset)); }))

    #else

    -#define __reloc_hide(var, offset) (*({ \
    +#define SHIFT_PERCPU_PTR(ptr, offset) (({ \
    extern int simple_identifier_##var(void); \
    unsigned long __ptr; \
    - asm ( "" : "=a" (__ptr) : "0" (&per_cpu__##var) ); \
    - (typeof(&per_cpu__##var)) (__ptr + (offset)); }))
    + asm ( "" : "=a" (__ptr) : "0" (ptr) ); \
    + (typeof(ptr)) (__ptr + (offset)); }))

    #endif

    -#ifdef CONFIG_SMP
    +#define __my_cpu_offset S390_lowcore.percpu_offset

    -extern unsigned long __per_cpu_offset[NR_CPUS];
    -
    -#define __get_cpu_var(var) __reloc_hide(var,S390_lowcore.percpu_offset)
    -#define __raw_get_cpu_var(var) __reloc_hide(var,S390_lowcore.percpu_offset)
    -#define per_cpu(var,cpu) __reloc_hide(var,__per_cpu_offset[cpu])
    -#define per_cpu_offset(x) (__per_cpu_offset[x])
    -
    -/* A macro to avoid #include hell... */
    -#define percpu_modcopy(pcpudst, src, size) \
    -do { \
    - unsigned int __i; \
    - for_each_possible_cpu(__i) \
    - memcpy((pcpudst)+__per_cpu_offset[__i], \
    - (src), (size)); \
    -} while (0)
    -
    -#else /* ! SMP */
    -
    -#define __get_cpu_var(var) __reloc_hide(var,0)
    -#define __raw_get_cpu_var(var) __reloc_hide(var,0)
    -#define per_cpu(var,cpu) __reloc_hide(var,0)
    -
    -#endif /* SMP */
    -
    -#define DECLARE_PER_CPU(type, name) extern __typeof__(type) per_cpu__##name
    +#include <asm-generic/percpu.h>

    #endif /* __ARCH_S390_PERCPU__ */
    --


    \
     
     \ /
      Last update: 2008-01-08 03:15    [W:3.773 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site