Messages in this thread | | | Date | Mon, 7 Jan 2008 20:22:59 +0100 | From | Sam Ravnborg <> | Subject | Re: STT_FUNC for assembler checksum and semaphore ops |
| |
On Mon, Jan 07, 2008 at 09:23:37AM -0800, John Reiser wrote: > Dear $ARCH Maintainers, > > This patch adds Elf32_Sym .st_info (STT_FUNC) and .st_size for hand-coded > checksum and semaphore subroutines. I needed this info when writing a > static analyzer for stack depth [grovel over ./vmlinux] on the um > (UserModeLinux) $ARCH for i386. The changes work on i386. Other $ARCH > are analogous but not tested. Other arch/x86/lib/*.S are not used by um > currently. [Should analogous changes be made anyway?] > > Comments?
I do not know the assembly stuff in question, but the code you add would be nicer if packed in a macro. You may even use _GLOBAL and/or ENTRY for your purpose.
Sam
| |