lkml.org 
[lkml]   [2008]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] power_supply: add few more values and props
    On Sun, Jan 06, 2008 at 03:27:18PM +0300, Dmitry Baryshkov wrote:
    > Add LiMn (one of the most common for small non-rechargable batteries)i
    > battery technology and voltage_min/_max properties support.
    >
    > Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>

    Much thanks, all patches look good to me. Few questions about
    this one though.

    > diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
    > index 249f61b..45d2f95 100644
    > --- a/drivers/power/power_supply_sysfs.c
    > +++ b/drivers/power/power_supply_sysfs.c
    > @@ -46,7 +46,8 @@ static ssize_t power_supply_show_property(struct device *dev,
    > "Unspecified failure"
    > };
    > static char *technology_text[] = {
    > - "Unknown", "NiMH", "Li-ion", "Li-poly", "LiFe", "NiCd"
    > + "Unknown", "NiMH", "Li-ion", "Li-poly", "LiFe", "NiCd",
    > + "LiMn"
    > };
    > static char *capacity_level_text[] = {
    > "Unknown", "Critical", "Low", "Normal", "High", "Full"
    > @@ -88,6 +89,8 @@ static struct device_attribute power_supply_attrs[] = {
    > POWER_SUPPLY_ATTR(present),
    > POWER_SUPPLY_ATTR(online),
    > POWER_SUPPLY_ATTR(technology),
    > + POWER_SUPPLY_ATTR(voltage_max),
    > + POWER_SUPPLY_ATTR(voltage_min),

    I'd suggest keep Documentation/power_supply_class.txt in sync
    wrt new properties, to distinct their meanings and usage.

    I assume you're using these new properties for non-rechargeable
    LiMn batteries. So, why new properties, aren't voltage_*_design
    ones suits that purpose? If battery is non-rechargeable it is
    having only design values, no?

    > POWER_SUPPLY_ATTR(voltage_max_design),
    > POWER_SUPPLY_ATTR(voltage_min_design),
    > POWER_SUPPLY_ATTR(voltage_now),
    > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
    > index 606c095..cdbc5b8 100644
    > --- a/include/linux/power_supply.h
    > +++ b/include/linux/power_supply.h
    > @@ -54,6 +54,7 @@ enum {
    > POWER_SUPPLY_TECHNOLOGY_LIPO,
    > POWER_SUPPLY_TECHNOLOGY_LiFe,
    > POWER_SUPPLY_TECHNOLOGY_NiCd,
    > + POWER_SUPPLY_TECHNOLOGY_LiMn,
    > };
    >
    > enum {
    > @@ -72,6 +73,8 @@ enum power_supply_property {
    > POWER_SUPPLY_PROP_PRESENT,
    > POWER_SUPPLY_PROP_ONLINE,
    > POWER_SUPPLY_PROP_TECHNOLOGY,
    > + POWER_SUPPLY_PROP_VOLTAGE_MAX,
    > + POWER_SUPPLY_PROP_VOLTAGE_MIN,
    > POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN,
    > POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,
    > POWER_SUPPLY_PROP_VOLTAGE_NOW,


    Thanks,

    --
    Anton Vorontsov
    email: cbou@mail.ru
    backup email: ya-cbou@yandex.ru
    irc://irc.freenode.net/bd2


    \
     
     \ /
      Last update: 2008-01-06 15:25    [W:4.475 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site