Messages in this thread | | | Date | Sun, 6 Jan 2008 11:58:21 +0100 | From | "Paolo Ciarrocchi" <> | Subject | Re: [PATCH] profile: further Codying Style fixes |
| |
On Jan 6, 2008 11:25 AM, Ingo Molnar <mingo@elte.hu> wrote: > > * Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote: > > > Further codying style fixes on top of: > > http://marc.info/?l=linux-kernel&m=119940325306693&w=2 > > thanks, applied.
Hi Ingo, I posted a new version of that patch: http://lkml.org/lkml/2008/1/4/197 It's in your inbox with subject: [PATCH] profile: further Codying Style fixes, take 2
The patch you applied was changing the funtionality in case of non-SMP build. This was reported by Sam Ravnborg , see: http://linux.derkeiler.com/Mailing-Lists/Kernel/2008-01/msg01383.html
Can you please apply the new patch?
> > 1 Warning is still not killed: > > WARNING: externs should be avoided in .c files > > #509: FILE: profile.c:509: > > + extern int setup_profiling_timer(unsigned int multiplier); > > > > I don't know how to fix it :-/ > > simply move that line to include/linux/profile.h. (no need to preserve > the CONFIG_SMP - on !SMP the function prototype line will not be used)
Thanks.
Ciao, -- Paolo http://paolo.ciarrocchi.googlepages.com/
| |