Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] PM: Acquire device locks on suspend | Date | Sun, 6 Jan 2008 23:24:14 +0100 |
| |
On Sunday, 6 of January 2008, Alan Stern wrote: > On Sun, 6 Jan 2008, Rafael J. Wysocki wrote: > > > On Sunday, 6 of January 2008, Alan Stern wrote: > > > Still, shouldn't we fail the removal of the device apart from giving the > > warning? > > We can't. device_del() can't fail -- it returns void. Besides, how > can a driver hope to deal with an unregistration failure?
Well, right.
Still, our present approach doesn't seem to be correct overall. For example, I think we should prevent a suspend from happening while a device is being removed.
Rafael
| |