Messages in this thread | | | Date | Sun, 6 Jan 2008 13:40:05 -0600 | From | Olof Johansson <> | Subject | Re: [patch 2/5] move WARN_ON() out of line |
| |
On Sat, Jan 05, 2008 at 07:09:59PM -0800, Arjan van de Ven wrote: > From: Arjan van de Ven <arjan@linux.intel.com> > CC: Ingo Molnar <mingo@elte.hu> > CC: Andrew Morton <akpm@linux-foundation.org> > CC: Olof Johansson <olof@lixom.net> > Acked-by: Matt Meckall <mpm@selenic.com> > > A quick grep shows that there are currently 1145 instances of WARN_ON > in the kernel. Currently, WARN_ON is pretty much entirely inlined, > which makes it hard to enhance it without growing the size of the kernel > (and getting Andrew unhappy). > > This patch build on top of Olof's patch that introduces __WARN, > and places the slowpath out of line. It also uses Ingo's suggestion > to not use __FUNCTION__ but to use kallsyms to do the lookup; > this saves a ton of extra space since gcc doesn't need to store the function > string twice now: > > 3936367 833603 624736 5394706 525112 vmlinux.before > 3917508 833603 624736 5375847 520767 vmlinux-slowpath > > 15Kb savings... > > Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: Olof Johansson <olof@lixom.net>
| |