lkml.org 
[lkml]   [2008]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RESEND PATCH 09/10] ide-floppy: use test_bit wrappers for testing flags
Date

There are two issues here:

* set_bit()/test_bit() are atomic operations and they don't see to be
necessary in case of ide-floppy.c (standard '|'/'&' should be enough)

* using wrappers for these operations is not a bad idea but doing it _now_
just makes it harder for us to figure out how to introduced common ATA
Packet command interface for all ATAPI device drivers (the other drivers
are using very similar flag handling and flag names currently)

so I would say that we should defer introducting these wrappers for now
(patch converting set_bit()/test_bit() to '|'/'&' would still be welcomed).

On Thursday 03 January 2008, Borislav Petkov wrote:
> also, fix header comments and remove superfluous ones. There should be no
> functionality change resulting from this patch.

fixes for comments look fine but they should be merged with the other
patch (the one containing checkpatch.pl/comments fixes)

Thanks,
Bart


\
 
 \ /
  Last update: 2008-01-05 17:03    [W:0.113 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site