Messages in this thread | | | Date | Fri, 04 Jan 2008 02:38:35 -0800 | From | Arjan van de Ven <> | Subject | Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON() |
| |
Ingo Molnar wrote: > * Arjan van de Ven <arjan@linux.intel.com> wrote: > >> + printk(KERN_WARNING "------------[ cut here ]------------\n"); >> printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file, >> line, function); >> + print_modules(); >> dump_stack(); >> + print_oops_end_marker(); > > another thing: could we also put the marker into dump_stack(), and > attach the marker to the Call Trace line? >
I have a preliminary patch for that already but I'm not happy with it yet; I need to redo it properly. It's neither depending nor incremental to these 2 patches though..
| |