lkml.org 
[lkml]   [2008]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH x86] [7/16] Convert lockdep to use arch_early_alloc() if available for its large arrays

    * Andi Kleen <ak@suse.de> wrote:

    > +#ifndef ARCH_HAS_EARLY_ALLOC
    > +#define LARGEVAR(x,y) { static typeof(*x) __ ## x[y]; x = __ ## x; }
    > +#else
    > +#define LARGEVAR(x,y) x = arch_early_alloc(sizeof(*x) * y)
    > +#endif

    your patch makes sense in principle, but please do this via the Kconfig
    space - we dont introduce new ARCH_HAS flags anymore and try to get rid
    of the existing ones as well.

    Ingo


    \
     
     \ /
      Last update: 2008-01-04 10:07    [W:0.022 / U:29.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site