Messages in this thread | | | Date | Fri, 4 Jan 2008 13:13:40 -0600 | From | Paul Jackson <> | Subject | Re: [PATCH] PROC_FS: get and set the smp affinity of tasks by read-write /proc/<pid>/smp_affinity |
| |
rael wrote: > length check copied from kernel/irq/proc.c, now 'page' buffer couldn't > be overrun,
Thanks.
> although Documentation/filesystems/proc.txt is heavily outdated, > I'll add introduction of smp_affinity.
Good - my usual benchmark for documentation is that at least one place in the code or associated documentation clearly describes things.
My main concern in this patch was that there were zero instances of documentation of this new /proc file. The patch should include a text explanation of this feature, and put it somewhere.
Documentation/filesystems/proc.txt looked like a reasonable place, but I don't really care where, nor do I lose as much sleep as I should when some documentation is incomplete or stale. Just so long as everything is clearly explained somewhere.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.940.382.4214
| |