Messages in this thread Patch in this message | | | Date | Fri, 1 Feb 2008 02:05:09 +0100 | From | Pavel Machek <> | Subject | Re: kill misleading comments in trampoline_*.S |
| |
On Thu 2008-01-31 17:02:29, Yinghai Lu wrote: > On Jan 31, 2008 4:54 PM, Pavel Machek <pavel@ucw.cz> wrote: > > > > > > Both trampolines actually *do* set up stack. (Is the "we jump into > > compressed/head.S" comment still true?) > > > > Signed-off-by: Pavel Machek <pavel@suse.cz> > > > > diff --git a/arch/x86/kernel/trampoline_32.S b/arch/x86/kernel/trampoline_32.S > > index 9bcc1c6..5398547 100644 > > --- a/arch/x86/kernel/trampoline_32.S > > +++ b/arch/x86/kernel/trampoline_32.S > > @@ -11,9 +11,6 @@ > > * trampoline page to make our stack and everything else > > * is a mystery. > > * > > - * In fact we don't actually need a stack so we don't > > - * set one up. > > - * > > * We jump into the boot/compressed/head.S code. So you'd > > * better be running a compressed kernel image or you > > * won't get very far. > > should be arch/x86/kernel/head_32.S
Thanks, fixed in my local copy. But that's separate problem. ;-).
Pavel
diff --git a/arch/x86/kernel/trampoline_32.S b/arch/x86/kernel/trampoline_32.S index 9bcc1c6..6458067 100644 --- a/arch/x86/kernel/trampoline_32.S +++ b/arch/x86/kernel/trampoline_32.S @@ -11,12 +11,7 @@ * trampoline page to make our stack and everything else * is a mystery. * - * In fact we don't actually need a stack so we don't - * set one up. - * - * We jump into the boot/compressed/head.S code. So you'd - * better be running a compressed kernel image or you - * won't get very far. + * We jump into arch/x86/kernel/head_32.S. * * On entry to trampoline_data, the processor is in real mode * with 16-bit addressing and 16-bit data. CS has some value diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S index e30b67c..4aedd0b 100644 --- a/arch/x86/kernel/trampoline_64.S +++ b/arch/x86/kernel/trampoline_64.S @@ -10,9 +10,6 @@ * trampoline page to make our stack and everything else * is a mystery. * - * In fact we don't actually need a stack so we don't - * set one up. - * * On entry to trampoline_data, the processor is in real mode * with 16-bit addressing and 16-bit data. CS has some value * and IP is zero. Thus, data addresses need to be absolute
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |