lkml.org 
[lkml]   [2008]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectx86: Why have __copy_from_user_ll_nocache* been exported?
A commit that does nothing except for adding two unused EXPORT_SYMBOL's.

Without any rationale why they should be exported.

And that from a person who on the other hand wants to introduce
(and tries to force on other people) deprecation periods for unused
EXPORT_SYMBOL's.

Can we please get this reverted quickly?

TIA
Adrian


commit 914c82694cadbab511f2aee8a59c89be2938bace
Author: Andrew Morton <akpm@osdl.org>
Date: Wed Jan 30 23:27:57 2008 +0100

x86: export copy_from_user_ll_nocache[_nozero]

Cc: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/arch/x86/lib/usercopy_32.c b/arch/x86/lib/usercopy_32.c
index 8bab2b2..9c4ffd5 100644
--- a/arch/x86/lib/usercopy_32.c
+++ b/arch/x86/lib/usercopy_32.c
@@ -817,6 +817,7 @@ unsigned long __copy_from_user_ll_nocache(void *to, const void __user *from,
#endif
return n;
}
+EXPORT_SYMBOL(__copy_from_user_ll_nocache);

unsigned long __copy_from_user_ll_nocache_nozero(void *to, const void __user *from,
unsigned long n)
@@ -831,6 +832,7 @@ unsigned long __copy_from_user_ll_nocache_nozero(void *to, const void __user *fr
#endif
return n;
}
+EXPORT_SYMBOL(__copy_from_user_ll_nocache_nozero);

/**
* copy_to_user: - Copy a block of data into user space.



\
 
 \ /
  Last update: 2008-01-31 21:17    [W:1.895 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site