Messages in this thread | | | Date | Thu, 31 Jan 2008 18:39:41 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages |
| |
On Thu, Jan 31, 2008 at 06:10:02PM +0100, Thomas Gleixner wrote: > On Thu, 31 Jan 2008, Andi Kleen wrote: > > > On Thu, Jan 31, 2008 at 05:17:41PM +0100, Thomas Gleixner wrote: > > > On Tue, 29 Jan 2008, Andi Kleen wrote: > > > > > > > > +static unsigned long direct_entry(unsigned long paddr) > > > > > > Please use a more sensible function name. This one has no association > > > with the functionality at all. > > > > Can you suggest one? I honestly cannot think of a better one. > > Its's a "entry" in the "direct" mapping. > > Doh, yes :) It just did not trigger.
I got rid of it now by switching over to the standard pte primitives (with the usual casts). It's not prettier, but at least more consistent.
I hope i didn't break the paravirt case though, we'll see.
-Andi
| |