Messages in this thread | | | Date | Thu, 31 Jan 2008 18:24:23 +0200 | From | Adrian Bunk <> | Subject | Re: [git pull] x86 arch updates for v2.6.25 |
| |
On Thu, Jan 31, 2008 at 05:15:23PM +0100, Ingo Molnar wrote: > > * Adrian Bunk <bunk@kernel.org> wrote: > > > On Thu, Jan 31, 2008 at 05:00:33PM +0100, Ingo Molnar wrote: > > > > > > * Adrian Bunk <bunk@kernel.org> wrote: > > > > > > > You tested x86 but broke more than half a dozen other archtectures, > > > > with at least 3 different commits breaking other architectures. > > > > > > Note that all known breakages are fixed in current -git, except for the > > > s390 problem that Martin/Nick posted the fix. > > > > What about the breakages caused by commit > > a5a19c63f4e55e32dc0bc3d936d7f94793d8b380 (this commit broke the > > defconfig compilation on at least avr32, blackfin, sh, sparc and uml)? > > the patch below fixes that.
Is it safe, or why did Jeremy state in the commit "I removed this include to avoid an include cycle"?
> Ingo > > --- > include/asm-generic/tlb.h | 1 + > 1 file changed, 1 insertion(+) > > Index: linux/include/asm-generic/tlb.h > =================================================================== > --- linux.orig/include/asm-generic/tlb.h > +++ linux/include/asm-generic/tlb.h > @@ -15,6 +15,7 @@ > > #include <linux/swap.h> > #include <linux/quicklist.h> > +#include <asm/pgalloc.h> > #include <asm/tlbflush.h> > > /*
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |