Messages in this thread | | | Date | Thu, 31 Jan 2008 08:11:20 -0800 | From | Arjan van de Ven <> | Subject | Re: [PATCH] kill hotplug init/exit section annotations |
| |
On Thu, 31 Jan 2008 09:57:31 -0600 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> No-one seems to see much value in these, and they cause about 90% of > our problems with __init/__exit markers, so simply eliminate them. > Rather than run over the whole tree removing them, this patch > #defines them to be nops. > > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> > > --- > > I'll probably be going after __exit after this one, but it makes sense > to split them up, since the hotplug annotation removal looks > uncontroversial, whereas __exit and discard section removal might > produce more robust debate. I also think doing the hotplug removal > gives us 90% of the benefits and removes 90% of the section mismatch > problems.
Since hotplug is so fundamental nowadays the value no longer outweighs the pain/cost to me, so
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
-- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |