lkml.org 
[lkml]   [2008]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 4/6] Add multi mport support.
Date
From


> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org]
>
> On Jan 31, 2008, at 12:15 AM, Kumar Gala wrote:
>
> >
> > On Jan 30, 2008, at 11:57 PM, Zhang Wei wrote:
> >
> >>
> >>
> >>> -----Original Message-----
> >>> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> >>>
> >>> On Jan 30, 2008, at 4:30 AM, Zhang Wei wrote:
> >>>
> >>>> Change lots of static variable to mport private. And add
> >>> mport to some
> >>>> function declaration.
> >>>
> >>> Can you explain this patch further. Its not clear
> exactly from this
> >>> commit message why we are doing this.
> >>>
> >>> - k
> >>
> >> Sorry about I have a little hurry about it.
> >>
> >> The original RapidIO driver suppose there is only one mpc85xx RIO
> >> controller
> >> in system. So, some data structures are defined as mpc85xx_rio
> >> global,
> >> such as 'regs_win', 'dbell_ring', 'msg_tx_ring'. Now, I
> changed them
> >> to
> >> mport's private members. And you can define multi RIO
> OF-nodes in dts
> >> file
> >> for multi RapidIO controller in one processor, such as PCI/PCI-Ex
> >> host
> >> controllers
> >> in Freescale's silicon. And the mport operation function
> declaration
> >> should be changed
> >> to know which RapidIO controller is target.
> >
> > thanks, this makes a lot of sense and now reviewing the patch will
> > make some sense to me :)
>
> when we have multiple ports are the device IDs on the ports intended
> to be unique only to a port or unique across all ports?
>
I consider each RIO controller will has its own network, the device IDs
should be
unique only in its port network.

Cheers!
Wei


\
 
 \ /
  Last update: 2008-01-31 07:33    [W:0.148 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site