lkml.org 
[lkml]   [2008]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH] x86_64: make bootmap_start page align v4
On Wednesday 30 January 2008 11:08:32 am Andi Kleen wrote:
>
> > + /*
> > + * when you have 64g or 128g ram, bootmap will be pushed after bss
> > + * section, the bootmap we get from early_node_mem via find_e820_area
> > + * is not page aligned, we need to round it up to make sure bootmap
> > + * is not overlapped with bss section
> > + */
> > + bootmap_start = round_up(bootmap_start, PAGE_SIZE);
>
> The better solution would be to PAGE_ALIGN() the addresses
> in bad_addr(). Or better fix it that no such alignment is needed to not
> get conflicts.

I don't think so, that is setup_node_bootmem's problem.

it is supposed to round_up instead of just do PAGE_SHIFT...

other caller will just use the address instead change it page.

YH


\
 
 \ /
  Last update: 2008-01-30 21:19    [from the cache]
©2003-2011 Jasper Spaans