Messages in this thread | | | Date | Wed, 30 Jan 2008 10:20:47 -0800 | From | Arjan van de Ven <> | Subject | Re: [PATCH] x86: Add a list for custom page fault handlers. |
| |
On Sun, 27 Jan 2008 18:52:38 +0200 Pekka Paalanen <pq@iki.fi> wrote:
> From: Pekka Paalanen <pq@iki.fi> > > Provides kernel modules a way to register custom page fault handlers. > On every page fault, except those handled in vmalloc_fault(), this > will call a list of registered functions. The functions may handle > the fault and force do_page_fault() to return immediately. > > This functionality is similar to the now removed page fault notifiers. > Custom page fault handlers are used by debugging and reverse > engineering tools. Mmio-trace is one such tool and a patch to add it > into the tree will follow. > > The custom page fault handlers are called from the exact same points > in do_page_fault() as the page fault notifiers were.
to be honest I don't like this approach. I fully would like to see mmio tracing in the kernel, but please make the hook explicit and direct (eg call the mmio tracing function, not some list) instead...
-- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |