lkml.org 
[lkml]   [2008]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch 1/6] mmu_notifier: Core code
    From
    Date

    On Wed, 2008-01-30 at 16:37 +0100, Andrea Arcangeli wrote:
    > On Tue, Jan 29, 2008 at 06:29:10PM -0800, Christoph Lameter wrote:
    > > +void mmu_notifier_release(struct mm_struct *mm)
    > > +{
    > > + struct mmu_notifier *mn;
    > > + struct hlist_node *n, *t;
    > > +
    > > + if (unlikely(!hlist_empty(&mm->mmu_notifier.head))) {
    > > + rcu_read_lock();
    > > + hlist_for_each_entry_safe_rcu(mn, n, t,
    > > + &mm->mmu_notifier.head, hlist) {
    > > + hlist_del_rcu(&mn->hlist);
    >
    > This will race and kernel crash against mmu_notifier_register in
    > SMP. You should resurrect the per-mmu_notifier_head lock in my last
    > patch (except it can be converted from a rwlock_t to a regular
    > spinlock_t) and drop the mmap_sem from
    > mmu_notifier_register/unregister.

    Agreed, sorry for this oversight.



    \
     
     \ /
      Last update: 2008-01-30 18:13    [W:0.025 / U:121.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site