lkml.org 
[lkml]   [2008]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [SIS190] Constify data marked as __devinitdata

    On Jan 30 2008 11:53, Jonas Bonn wrote:
    >
    >This fixes build error as gcc complains about a "section type conflict"
    >due to the const __devinitdata in sis190_get_mac_addr_from_apc().

    >-static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
    >+static const struct pci_device_id sis190_pci_tbl[] __devinitdata = {
    > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
    > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
    > { 0, },

    Eh? Did you mean to

    - static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
    + static u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };

    instead? Because AFAIK, const *and* __sectionmarker does not mix.


    \
     
     \ /
      Last update: 2008-01-30 12:25    [W:0.020 / U:0.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site