Messages in this thread | | | Date | Wed, 30 Jan 2008 05:38:38 -0500 | From | Jeff Garzik <> | Subject | Re: [git patches] net driver fixes |
| |
Sam Ravnborg wrote: >> Jeff Garzik (1): >> [netdrvr] sis190: build fix > > But you did it wrong... > sis190.c b/drivers/net/sis190.c >> index b570402..2e9e88b 100644 >> --- a/drivers/net/sis190.c >> +++ b/drivers/net/sis190.c >> @@ -326,7 +326,7 @@ static const struct { >> { "SiS 191 PCI Gigabit Ethernet adapter" }, >> }; >> >> -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { >> +static struct pci_device_id sis190_pci_tbl[] = { >> { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, >> { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, >> { 0, }, > > The __devinitdata is OK, it is the following _devinitdata that had to be _devinitconst.
Cool. Either way is fine with me. I just wanted to get a build fix upstream ASAP, one I was sure would work.
Jeff
| |