Messages in this thread | | | Date | Thu, 3 Jan 2008 12:23:50 +0100 | From | "pHilipp Zabel" <> | Subject | Re: [PATCH] teach checkpatch.pl about list_for_each |
| |
On Dec 2, 2007 1:03 PM, Christer Weinigel <christer@weinigel.se> wrote: > Hi Andy, > > you seem to be the last person messing around with checkpatch.pl so I'm > addressing this to you. :-) > > checkpatch complains about the following: > > WARNING: no space between function name and open parenthesis '(' > #520: FILE: drivers/spi/spi_s3c24xx_dma.c:478: > + list_for_each_entry (transfer, &message->transfers, transfer_list) { > > which I think is a bit bogus since it actually is a for statement in > disguise. The following patch adds list_for_each to the list of things > that look like functions that it shouldn't complain about. > > By the way, what is the consensus on lines over 80 characters? > checkpatch complains about the following: > > WARNING: line over 80 characters > #762: FILE: drivers/spi/spi_s3c24xx_dma.c:720: > + printk(KERN_INFO "S3C24xx SPI DMA driver (c) 2007 Nordnav Technologies AB\n"); > > I can of course break this into: > > printk(KERN_INFO "S3C24xx SPI DMA driver (c) 2007 Nordnav " > "Technologies AB\n");
I'd not split it in the middle of a name or phrase if possible. printk(KERN_INFO "S3C24xx SPI DMA driver" "(c) 2007 Nordnav Technologies AB\n"); but ...
> but in my opinion that becomes more even unreadable. Would it be > possible to add a special case so that checkpatch ignores long strings > that go beyond 80 characters? Do you think it is a good idea?
... in this case pr_info("S3C24xx SPI DMA driver (c) 2007 Nordnav Technologies AB\n"); might just push it under the limit.
cheers Philipp
| |