Messages in this thread | | | Date | Thu, 3 Jan 2008 08:24:04 +0100 | From | Jarek Poplawski <> | Subject | Re: [PATCH 0/7] convert semaphore to mutex in struct class |
| |
On Thu, Jan 03, 2008 at 08:06:09AM +0100, Jarek Poplawski wrote: > On Thu, Jan 03, 2008 at 01:50:20PM +0800, Dave Young wrote: > > Convert semaphore to mutex in struct class. > ... > > One lockdep warning detected as following, thus use mutex_lock_nested with SINGLE_DEPTH_NESTING in class_device_add > > > > Jan 3 10:45:15 darkstar kernel: ============================================= > > Jan 3 10:45:15 darkstar kernel: [ INFO: possible recursive locking detected ] > > Jan 3 10:45:15 darkstar kernel: 2.6.24-rc6-mm1-mutex #1 > > Jan 3 10:45:15 darkstar kernel: --------------------------------------------- > ... > > If there's anything missed please help to point out, thanks. > > Dave, IMHO it's not 'the right' way to do it: [...]
OOPS! (I was sleeping...) Unless it has turned out it's not so hard here, and you are quite sure there should be no more warnings after this one nesting annotation - then of course, this is the right way!
Sorry (?) Jarek P.
| |