lkml.org 
[lkml]   [2008]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1)
On Thu, Jan 03, 2008 at 02:23:44PM +0100, Jiri Slaby wrote:

> ISOFS: unable to read i-node block

isofs_read_inode() failing, about to do make_bad_inode()

> Unable to handle kernel NULL pointer dereference at 00000000000000ad RIP:
> [<ffffffff802a679f>] d_splice_alias+0x1f/0x100

struct dentry *d_splice_alias(struct inode *inode, struct dentry *dentry)
{
struct dentry *new = NULL;

if (inode && S_ISDIR(inode->i_mode)) {
^^^^^^^^^^^^^

> RIP: 0010:[<ffffffff802a679f>] [<ffffffff802a679f>] d_splice_alias+0x1f/0x100
> RSP: 0000:ffff810061543b08 EFLAGS: 00010282
> RAX: 00000000ffffffff RBX: fffffffffffffffb RCX: ffffffff880d3454
> RDX: ffff810048542750 RSI: ffff81005e114e10 RDI: fffffffffffffffb

with inode equal to (struct inode *)-5. Which is ERR_PTR(-EIO)...

> [<ffffffff880d2395>] :isofs:isofs_lookup+0x395/0x4a0

inode = NULL;
if (found) {
inode = isofs_iget(dir->i_sb, block, offset);
if (!inode) {
unlock_kernel();
return ERR_PTR(-EACCES);
}
}
unlock_kernel();
return d_splice_alias(inode, dentry);

So we've got ERR_PTR(-EIO) from isofs_iget(). Bloody odd, seeing that
isofs_iget() either explicitly returns NULL or does

if (inode && (inode->i_state & I_NEW)) {
sb->s_op->read_inode(inode);
unlock_new_inode(inode);
}

return inode;

which would not manage to return ERR_PTR(-EIO), no matter what - it would
die on access to inode->i_state. I don't have -mm tree at hand, check if
there's anything affected in these areas. Perhaps somebody tried to pass
error values from isofs_iget() and forgot to update callers?


\
 
 \ /
  Last update: 2008-01-03 15:13    [W:0.095 / U:7.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site