Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] [1/20] x86: Make ptrace.h safe to include from assembler code | Date | Thu, 3 Jan 2008 13:57:13 +0100 |
| |
On Thursday 03 January 2008 10:54:52 Ingo Molnar wrote: > > * Andi Kleen <ak@suse.de> wrote: > > > Index: linux/include/asm-x86/ptrace-abi.h > > =================================================================== > > --- linux.orig/include/asm-x86/ptrace-abi.h > > +++ linux/include/asm-x86/ptrace-abi.h > > @@ -80,6 +80,7 @@ > > > > #define PTRACE_SINGLEBLOCK 33 /* resume execution until next branch */ > > > > +#ifndef __ASSEMBLY__ > > hm, this patch misses a rationale - what assembly code includes > ptrace-abi.h directly or indirectly? Did you see any build breakage with > x86.git that requires this? (if yes then please send me the .config)
It's needed for the dwarf2 unwinder, but imho useful on its own.
-Andi
| |