Messages in this thread | | | Date | Mon, 28 Jan 2008 11:13:34 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: fix usage of .section .sched.text in assembler code |
| |
* Sam Ravnborg <sam@ravnborg.org> wrote:
> Without this patch the linker will generate a section named > .sched.text.1 which is unexpected. This is because the gcc generated > section has "ax" but the assembler usage of .sched.text lacks the "ax" > specifier.
thanks, applied.
> It would be better to have a definition we could use from assembler > code but I did not find a suitable header file for it.
hm, include/asm-x86/linkage.h?
btw., i guess this in include/linux/linkage.h:
#ifndef __ALIGN #define __ALIGN .align 4,0x90 #define __ALIGN_STR ".align 4,0x90" #endif
is an x86-ism (0x90 is the x86 NOP instruction) that should move into include/asm-x86/linkge.h and the default filler should be 0x00 instead?
Ingo
| |