lkml.org 
[lkml]   [2008]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm 2/2] PWM LED driver
On Mon, 28 Jan 2008 01:29:32 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> > - if (i > 0) {
> > - for (i = i - 1; i >= 0; i--) {
> > - led_classdev_unregister(&leds[i].cdev);
> > - pwm_channel_free(&leds[i].pwmc);
> > - }
> > + while (i-- > 0) {
> > + led_classdev_unregister(&leds[i].cdev);
> > + pwm_channel_free(&leds[i].pwmc);
> > }
>
> Looks OK, although I'd say that `while (--i >= 0)' is more idiomatic -
> predecrement, postincrement and all that?

Maybe. while (i-- > 0) has the advantage that it will work even if i is
unsigned though...

Haavard


\
 
 \ /
  Last update: 2008-01-28 10:35    [W:0.051 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site