Messages in this thread Patch in this message | | | Date | Tue, 29 Jan 2008 00:01:35 +0100 | From | Jan Kiszka <> | Subject | Re: [PATCH] KGDB: refactor kconfig menu |
| |
Jan Kiszka wrote: > Jan Kiszka wrote: >> This is an attempt to improve the so far, well, unfortunate Kconfig menu >> organization of KGDB. Most notably, it pushes all sub-entries into their >> own menuconfig, removes the (IMHO) unneeded "Method for KGDB >> communication" choice, and ensures everything is indented properly. This >> should keep the original semantic while reducing the number of knobs the >> user is confronted with. > > I realized that KGDB_8250_CONF_STRING is unused in case the driver is > built as module. So here comes an updated patch that exposes this option > only when it is actually needed.
Oh, I missed that part one is already in x86.git. So the delta is:
Ask for KGDB_8250_CONF_STRING only in the non-modular case.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
--- lib/Kconfig.kgdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/lib/Kconfig.kgdb =================================================================== --- a/lib/Kconfig.kgdb +++ b/lib/Kconfig.kgdb @@ -55,7 +55,7 @@ config KGDB_PORT_NUM
config KGDB_8250_CONF_STRING string "Configuration string for KGDB" - depends on KGDB_8250 && !KGDB_SIMPLE_SERIAL + depends on (KGDB_8250 = y) && !KGDB_SIMPLE_SERIAL default "io,2f8,115200,3" if X86 help The format of this string should be <io or mmio>,
| |