Messages in this thread Patch in this message | | | Date | Mon, 28 Jan 2008 19:11:13 +0100 | From | Ingo Molnar <> | Subject | Re: git-x86 oopses in acpi_ps_peek_opcode |
| |
* Andi Kleen <andi@firstfloor.org> wrote:
> > do you still see that crash? > > New the second oops in > allocate_threshold_blocks->sysfs_add_file->kobject_uevent_env happens > (see other mail)
that's a Linus -git problem, the upstream kobject changes - try Greg's and Yinghai Lu's patch below, does it help?
Ingo
Index: linux-x86.q/arch/x86/kernel/cpu/mcheck/mce_amd_64.c =================================================================== --- linux-x86.q.orig/arch/x86/kernel/cpu/mcheck/mce_amd_64.c +++ linux-x86.q/arch/x86/kernel/cpu/mcheck/mce_amd_64.c @@ -450,7 +450,8 @@ recurse: if (err) goto out_free; - kobject_uevent(&b->kobj, KOBJ_ADD); + if (b) + kobject_uevent(&b->kobj, KOBJ_ADD); return err; @@ -553,8 +554,9 @@ static __cpuinit int threshold_create_de unsigned int bank; int err = 0; + printk(KERN_DEBUG "threshold_create_device: cpu %d, bank_map=%02x\n", cpu, per_cpu(bank_map,cpu)); for (bank = 0; bank < NR_BANKS; ++bank) { - if (!(per_cpu(bank_map, cpu) & 1 << bank)) + if (!(per_cpu(bank_map, cpu) & (1 << bank))) continue; err = threshold_create_bank(cpu, bank); if (err) @@ -637,7 +639,7 @@ static void threshold_remove_device(unsi unsigned int bank; for (bank = 0; bank < NR_BANKS; ++bank) { - if (!(per_cpu(bank_map, cpu) & 1 << bank)) + if (!(per_cpu(bank_map, cpu) & (1 << bank))) continue; threshold_remove_bank(cpu, bank); }
| |