Messages in this thread | | | Date | Mon, 28 Jan 2008 12:03:33 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCHv2 1/9] x86: Unify whitespace and comments in arch/x86/boot/compressed/vmlinux_??.lds |
| |
thanks Ian, i've picked up your series into x86.git.
one small nit - when doing cleanups i've been consistently using this formatting for comments:
/* * Be careful parts of head_32.S assume startup_32 is at * address 0. */
instead of:
/* Be careful parts of head_32.S assume startup_32 is at * address 0. */
(this is just personal preference, both forms are CodingStyle conform. I like the former a bit more because it visually separates comments from previous lines of code more. [and comments have rarely any relationship to previous code - they apply to the following code lines.] Anyway, no need to resend the series - just please keep this in mind for future cleanups.)
Ingo
| |