lkml.org 
[lkml]   [2008]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 10/32] ide-tape: remove struct idetape_read_position_result_t
    Date
    On Sunday 27 January 2008, Borislav Petkov wrote:
    > From: Borislav Petkov <bbpetkov@yahoo.de>
    >
    > There should be no functional changes resulting from this patch.
    >
    > Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
    > ---
    > drivers/ide/ide-tape.c | 49 +++++++++++++++++------------------------------
    > 1 files changed, 18 insertions(+), 31 deletions(-)

    [...]

    > -static ide_startstop_t idetape_read_position_callback (ide_drive_t *drive)
    > +static ide_startstop_t idetape_read_position_callback(ide_drive_t *drive)
    > {
    > idetape_tape_t *tape = drive->driver_data;
    > - idetape_read_position_result_t *result;
    > + u8 *readpos = tape->pc->buffer;
    >
    > debug_log(DBG_PROCS, "Enter %s\n", __func__);
    >
    > if (!tape->pc->error) {
    > - result = (idetape_read_position_result_t *) tape->pc->buffer;
    > - debug_log(DBG_SENSE, "BOP - %s\n", result->bop ? "Yes" : "No");
    > - debug_log(DBG_SENSE, "EOP - %s\n", result->eop ? "Yes" : "No");
    > + debug_log(DBG_SENSE, "BOP - %s\n",
    > + !!(readpos[0] & 0x80) ? "Yes" : "No");
    > + debug_log(DBG_SENSE, "EOP - %s\n",
    > + !!(readpos[0] & 0x40) ? "Yes" : "No");
    > +
    > + if (!!(readpos[0] & 0x4)) {
    > + printk(KERN_INFO "ide-tape: Block location is unknown"
    > + "to the tape\n");

    all "!!" above are unnecessary

    Otherwise is fine but depends on patch #7 so I couldn't merge it
    (please move this patch near the beginning of the series).

    Thanks,
    Bart


    \
     
     \ /
      Last update: 2008-01-27 20:39    [W:0.024 / U:0.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site