Messages in this thread | | | Date | Sat, 26 Jan 2008 22:03:36 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] Fix procfs task exe symlink |
| |
> On Wed, 23 Jan 2008 10:29:37 -0800 Matt Helsley <matthltc@us.ibm.com> wrote: > > Andrew, please consider this patch for inclusion in -mm. > > ... >
Can't say that we're particularly exercised about mvfs's problems, but the current way of doing /proc/pid/exe is indeed a nasty hack.
> > fs/binfmt_flat.c | 3 + > fs/exec.c | 2 + > fs/proc/base.c | 77 ++++++++++++++++++++++++++++++++++++++++++++++ > fs/proc/internal.h | 1 > fs/proc/task_mmu.c | 34 -------------------- > fs/proc/task_nommu.c | 34 -------------------- > include/linux/init_task.h | 8 ++++ > include/linux/mm.h | 22 +++++++++++++ > include/linux/mm_types.h | 7 ++++ > include/linux/proc_fs.h | 14 +++++++- > kernel/fork.c | 3 + > mm/mmap.c | 22 ++++++++++--- > mm/nommu.c | 15 +++++++- > 13 files changed, 164 insertions(+), 78 deletions(-)
It's a fairly expensive fix though. Can't we just do a strcpy() somewhere at exec time?
| |