Messages in this thread | | | Date | Sun, 27 Jan 2008 09:28:06 -0500 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 3/3] x86: WARN_ON breakpoints from .kprobes.text section |
| |
Hi Abhishek,
Abhishek Sagar wrote: > Identify breakpoints in .kprobes.text section. These certainly aren't kprobe > traps. However, we make an exception for the breakpoint hardcoded into jprobe_return.
Sorry, I can not understand what issue these patches can solve. The breakpoint which is inserted by external debugger will be checked by kprobe_handler() and be passed to other exception_notify_handlers. In that case, we don't need to warn it. I think current code is enough simple.
Thank you,
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division
e-mail: mhiramat@redhat.com
| |