lkml.org 
[lkml]   [2008]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH -mm 1/2] Basic PWM driver for AVR32 and AT91
    On Thu, 24 Jan 2008 12:53:13 -0800
    David Brownell <david-b@pacbell.net> wrote:

    > On Thursday 24 January 2008, Haavard Skinnemoen wrote:
    > > +config ATMEL_PWM
    > > +       tristate "Atmel AT32/AT91 PWM support"
    > > +       depends on (AVR32 || AT91) && EXPERIMENTAL
    >
    > There's probably no need for EXPERIMENTAL except in the
    > limited sense of "young driver". :)

    Yeah, I don't think EXPERIMENTAL makes sense here. Either you need the
    PWM or you don't.

    > There's a bug there ... it should have used ARCH_AT91 instead
    > of just AT91. Or even ARCH_AT91SAM9263 || ARCH_AT91SAM9RL.

    I've turned it into ARCH_AT91. I think listing the specific chips that
    have it is a bit too much; it won't break if you enable it on a chip
    that doesn't have it, it will just be useless. That's what defconfigs
    are for, and we still want people that test allmodconfigs on e.g.
    AT91RM9200 to report any breakage.

    Patch below.

    Haavard

    diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
    index 03c0c27..23a9231 100644
    --- a/drivers/misc/Kconfig
    +++ b/drivers/misc/Kconfig
    @@ -15,7 +15,7 @@ if MISC_DEVICES

    config ATMEL_PWM
    tristate "Atmel AT32/AT91 PWM support"
    - depends on (AVR32 || AT91) && EXPERIMENTAL
    + depends on AVR32 || ARCH_AT91
    help
    This option enables device driver support for the PWM channels
    on certain Atmel prcoessors. Pulse Width Modulation is used for
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2008-01-27 15:19    [W:2.922 / U:0.808 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site