Messages in this thread | | | Date | Sat, 26 Jan 2008 08:26:04 -0500 | From | Theodore Tso <> | Subject | Re: [PATCH 24/49] ext4: add block bitmap validation |
| |
On Wed, Jan 23, 2008 at 02:06:54PM -0800, Andrew Morton wrote: > brelse() should only be used when the bh might be NULL - put_bh() > can be used here. > > Please review all ext4/jbd2 code for this trivial speedup.
I've reviewed all of the pending patches in the stable queue for this speedup, and applied them where necessary; it was useful, since I detected a buffer head leak in one of the patches while I was at it.
The ext4/jbd2 code as a whole still needs to be reviewed for this speedup, but I don't want to fix this in the initial stable push, lest I break something by accident. I'll put it in the "TO DO" queue.
Regards,
- Ted
| |