Messages in this thread | | | Date | Fri, 25 Jan 2008 21:13:57 +0100 | From | Wim Van Sebroeck <> | Subject | DMI: create dmi_get_slot() |
| |
Hi Len,
I saw you added the dmi_get_slot function recently. If I look in drivers/firmware/dmi_scan.c however I now see:
...
/** * dmi_get_system_info - return DMI data value * @field: data index (see enum dmi_field) * * Returns one DMI data value, can be used to perform * complex DMI data checks. */ const char *dmi_get_system_info(int field) { return dmi_ident[field]; } EXPORT_SYMBOL(dmi_get_system_info);
...
/** * dmi_get_slot - return dmi_ident[slot] * @slot: index into dmi_ident[] */ char *dmi_get_slot(int slot) { return(dmi_ident[slot]); }
Didn't we duplicate code here?
Greetings, Wim.
| |