lkml.org 
[lkml]   [2008]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] x86: fix some bugs about EFI runtime code mapping

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

>> +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
>> +static void __init runtime_code_page_mkexec(void)
>> +{
>> + efi_memory_desc_t *md;
>> + unsigned long end;
>> + void *p;
>> +
>> + if (!(__supported_pte_mask & _PAGE_NX))
>> + return;
>>
>
> On 32-bit non-PAE, _PAGE_NX == 0, so this if() statement should be
> sufficient to disable the whole function at compile time without
> needing the outer #if defined wrapper.

good point. The patch fixes bugs and the consolidation it does is very
nice so i've applied it already, but we could indeed further consolidate
it and make it a nice #ifdef-less function. Could one of you send an
add-on patch for this?

Ingo


\
 
 \ /
  Last update: 2008-01-25 10:23    [W:0.075 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site