lkml.org 
[lkml]   [2008]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 191/196] scsi: use class iteration api
    Date
    From: Dave Young <hidave.darkstar@gmail.com>

    Convert to use the class iteration api.

    Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
    Cc: James Bottomley <James.Bottomley@hansenpartnership.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/scsi/hosts.c | 24 +++++++++++++-----------
    1 files changed, 13 insertions(+), 11 deletions(-)

    diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
    index 24271a8..6325115 100644
    --- a/drivers/scsi/hosts.c
    +++ b/drivers/scsi/hosts.c
    @@ -429,6 +429,15 @@ void scsi_unregister(struct Scsi_Host *shost)
    }
    EXPORT_SYMBOL(scsi_unregister);

    +static int __scsi_host_match(struct class_device *cdev, void *data)
    +{
    + struct Scsi_Host *p;
    + unsigned short *hostnum = (unsigned short *)data;
    +
    + p = class_to_shost(cdev);
    + return p->host_no == *hostnum;
    +}
    +
    /**
    * scsi_host_lookup - get a reference to a Scsi_Host by host no
    *
    @@ -439,19 +448,12 @@ EXPORT_SYMBOL(scsi_unregister);
    **/
    struct Scsi_Host *scsi_host_lookup(unsigned short hostnum)
    {
    - struct class *class = &shost_class;
    struct class_device *cdev;
    - struct Scsi_Host *shost = ERR_PTR(-ENXIO), *p;
    + struct Scsi_Host *shost = ERR_PTR(-ENXIO);

    - down(&class->sem);
    - list_for_each_entry(cdev, &class->children, node) {
    - p = class_to_shost(cdev);
    - if (p->host_no == hostnum) {
    - shost = scsi_host_get(p);
    - break;
    - }
    - }
    - up(&class->sem);
    + cdev = class_find_child(&shost_class, &hostnum, __scsi_host_match);
    + if (cdev)
    + shost = scsi_host_get(class_to_shost(cdev));

    return shost;
    }
    --
    1.5.3.8


    \
     
     \ /
      Last update: 2008-01-25 09:15    [W:4.135 / U:0.816 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site